Conversation
✅ Deploy Preview for nextflow-training ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Nextflow linting complete! ❌ 4 files had 21 errors 💡 Tip: Click filename locations to go directly to that code. View all 21 issues
View formatting changes
|
pinin4fjords
reviewed
Jan 5, 2026
Collaborator
pinin4fjords
left a comment
There was a problem hiding this comment.
Mostly makes sense, like the diagrams! Feedback:
- I find the table icon in the image for metadata problematic. For any given instance of a process they'll usually be getting a single row of that sample sheet, so I find showing a table there a bit confusing.
- Why are we moving to lowercase process name given the nf-core convention for uppercase?
hello-nf-core/solutions/core-hello-part4/modules/local/cowpy/main.nf
Outdated
Show resolved
Hide resolved
Collaborator
Author
Collaborator
Author
|
@pinin4fjords I addressed your comments, lmkwyt about the diagrams. (Also did a bunch of formatting updates and syntax updates while I was at it) |
Collaborator
Yep, that'll do it! |
pinin4fjords
approved these changes
Jan 6, 2026
Collaborator
pinin4fjords
left a comment
There was a problem hiding this comment.
Approving to unblock you, once meta icons fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Assorted improvements following 2025 Q4 season