Add missing resource directives to essential scripting patterns solution#770
Merged
pinin4fjords merged 3 commits intomasterfrom Jan 13, 2026
Merged
Conversation
The FASTP solution file was missing the dynamic resource directives taught in Section 4 of the tutorial (cpus, memory, errorStrategy, maxRetries). This caused a mismatch when learners compared their work to the provided solution. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
✅ Deploy Preview for nextflow-training ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Nextflow linting complete! ❌ 4 files had 21 errors 💡 Tip: Click filename locations to go directly to that code. View all 21 issues
View formatting changes
|
- Remove extraneous safe navigation on quality_score (tutorial teaches safe navigation in Section 6 for run_id only, not quality_score) - Change filter condition from > to >= to match Section 5.2 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes solution files for the Essential Scripting Patterns side quest to match what learners would build by following the tutorial.
Changes
modules/fastp.nfAdded missing dynamic resource directives taught in Section 4:
cpus { meta.depth > 40000000 ? 4 : 2 }memory { 1.GB * task.attempt }errorStrategy 'retry'maxRetries 2main.nf?.) onquality_score- the tutorial teaches safe navigation in Section 6 forrun_idonly>to>=to match Section 5.2Testing
🤖 Generated with Claude Code