Update hello_nf-core training for nf-core 3.5.2#896
Merged
FriederikeHanssen merged 13 commits intonextflow-io:masterfrom Mar 2, 2026
Merged
Update hello_nf-core training for nf-core 3.5.2#896FriederikeHanssen merged 13 commits intonextflow-io:masterfrom
FriederikeHanssen merged 13 commits intonextflow-io:masterfrom
Conversation
- Update scaffold code and solutions to use topic channels (Channel.topic("versions")) instead of old softwareVersionsToYAML pattern
- Remove repo type prompt from module install docs (now set in .nf-core.yml by default)
- Fix stray backtick in section 1.5 import statement
- Bump nf-core version references from 3.4.1 to 3.5.2 across docs and devcontainer
- Fix hl_lines in section 1.3 scaffold block after topic channels code addition
- Add #!groovy syntax highlighting to closure inline code in 03_use_module.md
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Deploy Preview for nextflow-training ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Nextflow linting complete! ✅ 171 files had no errors View formatting changes
|
Add missing space after `{` in `.map{ meta, file -> file }` for
consistency with other inline closures in the same file.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove LLM-style patterns (Let's, feel free, Don't worry, exclamations) and replace with direct, professional phrasing throughout all lesson files. Also fix one incorrect hl_lines value in 02_rewrite_hello.md. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pinin4fjords
reviewed
Mar 2, 2026
pinin4fjords
reviewed
Mar 2, 2026
pinin4fjords
reviewed
Mar 2, 2026
Collaborator
pinin4fjords
left a comment
There was a problem hiding this comment.
As discussed, let's not let the Claude validation skill go wild. That's my fault, I added the skill, but I've been treating the language tips as suggestions, not gospel.
I also think we can't just skim past 20 lines from the template in the same way we did when it was a single line. I think either we need to explain what it means, or just include a step to strip it up-front if it's not part of the teaching.
Reverts commit b286635 which applied overly strict CLAUDE.md writing style rules (removing "Let's", exclamations, etc.) to hello_nf-core lessons. Per reviewer feedback, these style guidelines are suggestions not mandates, and the original tone is preferred. Retains the functional fix: hl_lines="4" → hl_lines="2" in 02_rewrite_hello.md, which corrected an incorrectly highlighted line. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add note in 02_rewrite_hello.md (section 1.3) flagging the Channel.topic block as boilerplate, deferred to Part 4 - Replace outdated "does very little" sentence in section 3 with an acknowledgement that the topic channel block is substantial but covered in Part 4 - Add new section 1.6 in 04_make_module.md explaining topic channels: motivate with reproducibility, explain the broadcast mechanism, and describe legacy versions.yml backwards compat - Move nf-core modules spec link into Takeaway, update Takeaway to include topic channels Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Rewrite section 1.6 in 04_make_module.md: concept-first explanation of topic channels, hands-on step adding topic:versions output to COWPY, run-and-verify step, backwards compat note - Add note at section 1.5.2 tree output pointing to section 1.6 - Update core-hello-part4 and core-hello-part5 cowpy/main.nf to use topic:versions syntax, remove legacy versions.yml approach - Update cat/cat nf-core module to latest version in all three solution directories (part3, part4, part5) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add new section 1.6 explaining topic channel version capture: concept-first, hands-on step, run-and-verify, backwards compat note - Add note at section 1.5.2 tree output pointing to section 1.6 - Update section 2.1.2 template code block to current nf-core format using topic:versions syntax instead of legacy versions.yml - Update core-hello-part4 and part5 cowpy/main.nf to use topic:versions - Update cat/cat nf-core module to latest version in part3/4/5 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
bentsherman
reviewed
Mar 2, 2026
Docs fixes: - 02_rewrite_hello: fix config→conf typo in directory path - 03_use_module: add missing word "contain" in metamap description - 03_use_module: fix inconsistent comment between sections 3.3 and 3.4 - 04_make_module: remove incorrect shebang from module file code blocks - 04_make_module: fix stray \*\* in ext.prefix description - 04_make_module: fix versions YAML to show stripped process names Solution updates (rebuilt from proper nf-core 3.5.2 scaffold): - core-hello-part2 through part5: rebuilt and verified end-to-end - composable-hello: comment out params.greeting to match docs - original-hello: add main.nf entrypoint for composable workflow Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
original-hello/ is the starting point for learners - it should not contain Part 2 tutorial modifications (named workflow, main.nf). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pinin4fjords
approved these changes
Mar 2, 2026
Collaborator
pinin4fjords
left a comment
There was a problem hiding this comment.
Looks good, I'm sure you'll find other refinements after delivery!
These are generated by nf-core tools and should not be reformatted. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The indentation errors were from editorconfig-checker, not prettier. These files are generated by nf-core tools with 2-space indent JSON. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ile-fixer hooks Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Channel.topic("versions")) instead of the oldsoftwareVersionsToYAML(ch_versions)pattern.nf-core.ymlnow includesrepository_type: pipelineby default in 3.5.2)Test plan
🤖 Generated with Claude Code