Fix taxonomy check for kingdom in training script#48
Merged
nextgenusfs merged 1 commit intonextgenusfs:mainfrom Apr 2, 2026
Merged
Fix taxonomy check for kingdom in training script#48nextgenusfs merged 1 commit intonextgenusfs:mainfrom
nextgenusfs merged 1 commit intonextgenusfs:mainfrom
Conversation
Fix to sometimes absent “kingdom” flag & bugs related to non-searchable NCBI species names
Owner
|
Thanks so much for the fix! This perfectly resolves the We've merged this PR and will also be applying the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time doing pull requests so don't get angry at me if something is wrong with the submission :)
Minor fix to sometimes absent “kingdom” flag & TypeError related to non-searchable NCBI species names.
non-searchable NCBI species names: for custom names runs were resulting in
TypeError:absent “kingdom” flag: for some species (like Paramoeba/Perkinsela) kingdom key can be absent, resulting in
KeyError: 'kingdom':{
"superkingdom": "Eukaryota",
"phylum": "Discosea",
...
}
{
"superkingdom": "Eukaryota",
"phylum": "Euglenozoa",
...
}