First cut of image viewer#51
Merged
Merged
Conversation
Collaborator
|
@joe-loco I particularly like having a good image grid primitive :) |
Member
|
Love it, look at it! 😻 |
Member
|
I guess another thing we want to support is having the images being the same wider width as the code cells? Not sure if we want to support this in addition to or as a replacement for the content width. |
mk
force-pushed
the
image-layouts
branch
4 times, most recently
from
c0ef959 to
d85caf1
Compare
mk
added a commit
that referenced
this pull request
Jan 21, 2022
This adds a default viewer for `java.awt.image.BufferedImage` that can be easily constructed in the JVM using `java.imageio.ImageIO/read`. In this iteration, the viewer will look at the dimensions of the image and pick a suitable layout depending on the size and aspect ratio of the image. Customization and captions will be supported in a follow-up. Co-authored-by: Martin Kavalar <mk@katercalling.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a default viewer for
java.awt.image.BufferedImagethat can be easily constructed in the JVM usingjava.imageio.ImageIO/read. In this iteration, the viewer will look at the dimensions of the image and pick a suitable layout depending on the size and aspect ratio of the image. Customization and captions will be supported in a follow-up.See https://snapshots.nextjournal.com/clerk/build/7fc947c54f179d266ad7a97228c75b31f99b89e4/index.html#/notebooks/viewers/image.clj about what this first version supports.