Simplify & clean up viewers#53
Merged
Merged
Conversation
Member
Author
|
@zampino @philomates if either of you want to look over this before I merge it, please do. |
philomates
approved these changes
Jan 13, 2022
Comment on lines
+12
to
+14
| #?@(:cljs [IFn | ||
| (-invoke [this x] ((:f this) x)) | ||
| (-invoke [this x y] ((:f this) x y))])) |
Contributor
There was a problem hiding this comment.
so on the :clj side we no longer want to implement IFn, right?
| (def elide-string-length 100) | ||
|
|
||
| (declare with-viewer*) | ||
| (declare with-viewer) |
Contributor
There was a problem hiding this comment.
I think this line can be removed completely
| {:pred string? :render-fn (quote v/string-viewer) :fetch-opts {:n 100}} | ||
| {:pred number? :render-fn '(fn [x] (v/html [:span.tabular-nums (if (js/Number.isNaN x) "NaN" (str x))]))}]) | ||
|
|
||
| (defn process-fns [viewers] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the viewer api by dropping the macros and requiring users to quote the
:render-fn. This should make it explicit and less magic as to what part of the viewers is evaluated on the JVM and what is sent over the wire to run in the browser.