Allow to bring your own css and js#55
Merged
Merged
Conversation
Also drop `live-js?` the config but introduce a `clerk.resource_manifest` JVM system property and use it to get live js in dev instead.
|
This PR makes that CSS is replaced completely. On the other hand it would be great to just enhance Clerk's CSS. For example: I want to add two or three custom classes only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets consumers opt into providing their own js and js by setting values in
nextjournal.clerk.config/ !resource->url. Also droplive-js?the config but introduce aclerk.resource_manifestJVM system property and use it to get live js in dev instead.