Refactor to avoid double parsing and make testing easier#57
Merged
Conversation
mk
requested review from
philomates and
zampino
and removed request for
philomates
philomates
approved these changes
Jan 18, 2022
| (analyze-doc {:graph (dep/graph)} doc)) | ||
| ([state doc] | ||
| (let [state-with-document (assoc state :doc doc) | ||
| code-cells (into [] (filter (comp #{:code} :type)) (:doc doc))] |
Contributor
There was a problem hiding this comment.
Probably worth lifting (into [] (filter (comp #{:code} :type)) (:doc doc)) into a helper and calling both here and from analyze-file
Contributor
There was a problem hiding this comment.
should analyze-doc ever care about the :markdown? option? If so it might be worth writing analyze-file read the file and pass it to analyze-doc for doing work on
zampino
approved these changes
Jan 18, 2022
| (analyze-doc {:graph (dep/graph)} doc)) | ||
| ([state doc] | ||
| (let [state-with-document (assoc state :doc doc) | ||
| code-cells (into [] (filter (comp #{:code} :type)) (:doc doc))] |
Collaborator
There was a problem hiding this comment.
Maybe inline bindings above?
mk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the hashing and eval to:
Could not resolve varerror that could previously occur in the second analysis pass.clerkfolder