Skip to content

feat: 5422 filter three-dot menu to accept/reject only on pending share rows#459

Merged
memurats merged 7 commits intostable32from
nmc/5422-sharing-pending-share-grid-view-and-three-dot-menu-hide-options
Apr 10, 2026
Merged

feat: 5422 filter three-dot menu to accept/reject only on pending share rows#459
memurats merged 7 commits intostable32from
nmc/5422-sharing-pending-share-grid-view-and-three-dot-menu-hide-options

Conversation

@suet-kei-chan
Copy link
Copy Markdown

@suet-kei-chan suet-kei-chan commented Apr 8, 2026

Hide all actions except Accept share and Reject share in the overflow popper menu for pending share rows. The popper is teleported to body so CSS :has() cannot reach it; a click capture listener with rAF retry and a MutationObserver handle the filtering.

Refactored pending share setup into a single setupPendingShare function with one shared MutationObserver for both row blocking and popper filtering.

Screenshot 2026-04-09 at 16 23 27 Screenshot 2026-04-09 at 16 23 35 Screenshot 2026-04-09 at 16 23 48

Hide all actions except Accept share and Reject share in the overflow
popper menu for pending share rows. The popper is teleported to body so
CSS :has() cannot reach it; a click capture listener with rAF retry and
a MutationObserver handle the filtering.

Refactored pending share setup into a single setupPendingShare function
with one shared MutationObserver for both row blocking and popper filtering.
@suet-kei-chan suet-kei-chan self-assigned this Apr 8, 2026
Disable pointer events on the name link in the pending shares view so
files cannot be opened before the share is accepted. The fix uses a
body class (nmc-pendingshares-view) set by JS based on the current URL,
since the accept-share action only exists in the teleported popper and
cannot be targeted via CSS :has() on the row.

Also removes the unreliable isPendingShareRow helper and replaces it
with isPendingSharesPage() for row click blocking.
Resize the file/folder type icon to 44x36 in the pending shares list view.
Scoped to list view only (.files-list:not(.files-list--grid)) to avoid
affecting the grid view icon layout.
Hide the Actions text label on action-item__menutoggle buttons that
contain the dots-horizontal-icon, showing only the icon.
@suet-kei-chan suet-kei-chan marked this pull request as ready for review April 9, 2026 14:24
@suet-kei-chan suet-kei-chan changed the title feat: filter three-dot menu to accept/reject only on pending share rows feat: 5422 filter three-dot menu to accept/reject only on pending share rows Apr 9, 2026
@memurats memurats merged commit 82911bd into stable32 Apr 10, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants