chore: update#107
Conversation
WalkthroughReorganized Vue component templates for EpicCard and EpicComment to adjust DOM structure and dropdown scope without altering logic. Updated CreateEpicCommentBeacon to initialize selectedMembers as an empty array; watcher still syncs to state.usersId. No changes to exported/public APIs. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant UI as CreateEpicCommentBeacon UI
participant VM as Component State
Note over VM: Initial state<br/>selectedMembers = []
User->>UI: Select members
UI->>VM: Update selectedMembers
activate VM
VM->>VM: watcher: state.usersId = selectedMembers.map(id)
deactivate VM
User->>UI: Submit comment
UI->>Backend: Send payload with usersId
Backend-->>UI: Ack
sequenceDiagram
autonumber
actor User
participant Row as EpicComment Row
participant DD as Dropdown (UDropdownMenu)
participant Card as ActiveCard (content)
Note over Row: Root is flex row (avatar + content)
User->>Card: Click inside content
Card->>DD: Toggle menu
DD-->>User: Show actions
User->>Row: Click on avatar/notifications
Note over Row,DD: No dropdown toggle (outside DD scope)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/atrium-telegram/app/components/form/CreateEpicCommentBeacon.vue (1)
84-92: Align form field name with schema and simplify watcher
- Rename
<UFormField name="members">toname="usersId"so validation errors fromcreateBeaconSchemasurface on the correct field.- (Optional) Replace the watcher with:
for clearer intent and immediate sync.watch(selectedMembers, newVal => { state.value.usersId = newVal.map(m => m.value) }, { immediate: true })
🧹 Nitpick comments (4)
apps/atrium-telegram/app/components/EpicComment.vue (2)
2-6: Add alt text for avatar (a11y).Provide an accessible alt; fallback to a generic when name is missing.
- <UAvatar :src="user?.avatarUrl ?? undefined" /> + <UAvatar + :src="user?.avatarUrl ?? undefined" + :alt="`${user?.name ?? ''} ${user?.surname ?? ''}`.trim() || 'User avatar'" + />
7-16: Revisit negative sideOffset on dropdown; potential clipping/overflow.Prefer aligning via
align: 'start'and small offsets instead of-32.- :content="{ - sideOffset: -32, - }" + :content="{ + align: 'start', + sideOffset: 4, + alignOffset: -8 + }"Validate in narrow containers to ensure the menu fully displays and remains clickable.
apps/atrium-telegram/app/components/EpicCard.vue (2)
16-19: Safe fallback for comments count.Avoid rendering nothing when
commentsis undefined.- <p>{{ epic?.comments.length }}</p> + <p>{{ epic?.comments?.length ?? 0 }}</p>
22-26: Normalize timedatetimeattribute to ISO.Improves semantics and machine-readability.
- <time - :datetime="epic.createdAt" + <time + :datetime="new Date(epic.createdAt).toISOString()" class="text-sm text-muted" v-text="format(new Date(epic.createdAt), 'от d MMMM yyyy', { locale: ru })" />
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
apps/atrium-telegram/app/components/EpicCard.vue(1 hunks)apps/atrium-telegram/app/components/EpicComment.vue(2 hunks)apps/atrium-telegram/app/components/form/CreateEpicCommentBeacon.vue(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (2)
apps/atrium-telegram/app/components/EpicComment.vue (1)
32-37: Notifications moved outside the dropdown – good separation.Scoped interaction is clearer and avoids accidental menu opens when clicking beacons.
apps/atrium-telegram/app/components/EpicCard.vue (1)
2-13: Template restructuring looks good.Cleaner inner wrapper; no logic impact observed.
1 participant
Summary by CodeRabbit
Style
Refactor