Skip to content

chore: some functions#13

Merged
hmbanan666 merged 1 commit into
mainfrom
agent-functions
Jul 22, 2025
Merged

chore: some functions#13
hmbanan666 merged 1 commit into
mainfrom
agent-functions

Conversation

@hmbanan666
Copy link
Copy Markdown
Collaborator

@hmbanan666 hmbanan666 commented Jul 22, 2025

Summary by CodeRabbit

  • New Features

    • Added the ability to filter partners by surname.
    • Introduced a tool to display the total count of partners.
  • Improvements

    • Partner list API now returns enriched partner data.
    • Enhanced partner filtering options for more precise search results.

@hmbanan666 hmbanan666 self-assigned this Jul 22, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jul 22, 2025

Walkthrough

This change updates partner-related tooling and API endpoints. It replaces the original partner listing tool with two new tools: one for counting partners and another for filtering by surname. The partner list API now returns enriched partner data. A new repository method for listing active partners without related data is introduced.

Changes

File(s) Change Summary
apps/web-app/server/services/tools.ts Renamed getPartnersTool to getPartnersCountTool (returns count, not list), added getPartnersBySurnameTool.
apps/web-app/server/api/agent/index.post.ts Updated imports and Agent tools: removed old tool, added new count and surname tools.
apps/web-app/server/api/partner/list.get.ts Changed repository call to return enriched partner data using listWithData().
packages/database/src/repository/partner.ts Added static method list() to return active partners without related data.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant API (partner/list.get)
    participant PartnerRepository

    Client->>API (partner/list.get): GET /partner/list
    API (partner/list.get)->>PartnerRepository: listWithData()
    PartnerRepository-->>API (partner/list.get): Active partners with related data
    API (partner/list.get)-->>Client: Response with enriched partner data
Loading
sequenceDiagram
    participant AgentAPI
    participant Tools
    participant PartnerRepository

    AgentAPI->>Tools: getPartnersCountTool
    Tools->>PartnerRepository: list()
    PartnerRepository-->>Tools: Active partners
    Tools-->>AgentAPI: Count

    AgentAPI->>Tools: getPartnersBySurnameTool(surname)
    Tools->>PartnerRepository: listWithData()
    PartnerRepository-->>Tools: Active partners with data
    Tools-->>AgentAPI: Filtered partners by surname
Loading

Estimated code review effort

2 (~15 minutes)

Possibly related PRs

  • feat: ai agent #12: Introduced the original AI agent setup and tools, which are directly modified and extended in this PR.

Poem

A rabbit hops through fields of code,
Where partners count and surnames show,
New tools appear, old ones go—
Listing friends both high and low.
With every hop, the data grows,
In carrot fields where logic flows! 🥕


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 21a68b6 and ab098d1.

📒 Files selected for processing (4)
  • apps/web-app/server/api/agent/index.post.ts (2 hunks)
  • apps/web-app/server/api/partner/list.get.ts (1 hunks)
  • apps/web-app/server/services/tools.ts (2 hunks)
  • packages/database/src/repository/partner.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (7)
packages/database/src/repository/partner.ts (1)

16-20: LGTM! Clean separation of concerns.

The new list() method provides a lightweight alternative to listWithData() by excluding related entities. This follows good practice by allowing callers to choose between performance-optimized queries and data-rich queries based on their needs.

apps/web-app/server/api/partner/list.get.ts (1)

4-4: Good choice to maintain API data richness.

Using listWithData() ensures the API endpoint continues to return complete partner information with related kitchens data, maintaining backward compatibility for API consumers.

apps/web-app/server/api/agent/index.post.ts (2)

5-5: Import statement correctly updated.

The import properly includes the new specialized tools that replace the generic getPartnersTool.


47-48: Tools array properly configured with specialized tools.

The replacement of a generic partner listing tool with specific getPartnersBySurnameTool and getPartnersCountTool provides better granularity for the AI agent's capabilities.

apps/web-app/server/services/tools.ts (3)

5-14: Well-refactored count tool.

The transformation from a list-returning tool to a count-returning tool is clean and efficient. Using the new list() method is appropriate since only the count is needed.


24-25: No kitchen data needed for city filtering

The getPartnersByCityTool (and similarly getPartnersBySurnameTool) only uses the city (or surname) field on the Partner model—both are direct properties returned by repository.partner.list(). There are no references to kitchen-related fields in the filtering logic, so switching from listWithData() to list() is safe and improves performance.


29-40: Confirmed surname field in Partner model

The partners table and Partner type both include a properly typed surname column—no changes required.

• packages/database/src/tables.ts:83–84 defines surname: varchar('surname').notNull().default('')
• packages/database/src/types.ts: Partner = InferSelectModel<typeof tables.partners> includes surname: string

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud
Copy link
Copy Markdown

@hmbanan666 hmbanan666 merged commit c3c9f08 into main Jul 22, 2025
8 checks passed
@hmbanan666 hmbanan666 deleted the agent-functions branch July 22, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant