chore: visual update#156
Conversation
WalkthroughMinor presentation updates across three Vue components: adjusted a button’s animation timing/direction, tweaked spacing and avatar size in a staff block, and replaced a status verb in a kitchens flow message. No logic, data flow, or public API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (6)
apps/atrium-telegram/app/components/Navigation.vue (3)
9-9: Add an accessible label for the icon-only primary button.The plus-only UButton lacks a text label; add an aria-label to keep it screen‑reader friendly.
- class="transition-all duration-200 ease-in-out motion-preset-slide-up motion-duration-1000" + aria-label="Добавить" + class="transition-all duration-200 ease-in-out motion-preset-slide-up motion-duration-1000"
9-9: Respect reduced‑motion preferences.Gate the long entrance motion behind prefers‑reduced‑motion to avoid motion sickness.
- class="transition-all duration-200 ease-in-out motion-preset-slide-up motion-duration-1000" + class="transition-all duration-200 ease-in-out motion-safe:motion-preset-slide-up motion-safe:motion-duration-1000 motion-reduce:transition-none motion-reduce:motion-duration-0"
9-9: 1s entrance feels slow for a primary action; verify spec.Consider shortening to improve perceived responsiveness.
- class="transition-all duration-200 ease-in-out motion-preset-slide-up motion-duration-1000" + class="transition-all duration-200 ease-in-out motion-preset-slide-up motion-duration-300"apps/atrium-telegram/app/components/StaffBlock.vue (2)
3-3: Make spacing responsive to avoid early wrapping on narrow screens.The larger gap can cause premature wraps in the horizontal scroller; consider responsive gaps.
- <div class="w-max flex flex-row flex-wrap gap-2"> + <div class="w-max flex flex-row flex-wrap gap-1 sm:gap-2">
13-13: Provide alt text (or mark decorative) for the avatar.Improve a11y by setting an alt; if decorative, use empty alt or aria-hidden.
- <UAvatar + <UAvatar :src="user?.avatarUrl ?? undefined" - class="size-16 border-2 border-default" + :alt="`${user.name} ${user.surname}`" + class="size-16 border-2 border-default"apps/atrium-telegram/app/components/flow/KitchensOnline.vue (1)
18-19: Confirm Russian pluralization edge cases (0, 11–14, 111–114).If pluralizationRu already handles RU rules, great; if not, outputs like “11 Кухонь сейчас открыты” will be wrong. Consider Intl.PluralRules('ru') or vue‑i18n ICU.
Example (non-breaking refactor later):
const pr = new Intl.PluralRules('ru')
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apps/atrium-telegram/app/components/Navigation.vue(1 hunks)apps/atrium-telegram/app/components/StaffBlock.vue(2 hunks)apps/atrium-telegram/app/components/flow/KitchensOnline.vue(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
1 participant
Summary by CodeRabbit