Skip to content

chore: some welcome info#221

Merged
hmbanan666 merged 1 commit into
mainfrom
telegram-chore
Oct 14, 2025
Merged

chore: some welcome info#221
hmbanan666 merged 1 commit into
mainfrom
telegram-chore

Conversation

@hmbanan666
Copy link
Copy Markdown
Collaborator

@hmbanan666 hmbanan666 commented Oct 14, 2025

Summary by CodeRabbit

  • New Features
    • Ticket counter badge now caps at “10+” when there are more than 10 unread items, improving readability.
    • Telegram bot now sends clearer success messages, including a follow-up with a link to the Atrium web version and the access key for easier access.

@hmbanan666 hmbanan666 self-assigned this Oct 14, 2025
@sonarqubecloud
Copy link
Copy Markdown

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Oct 14, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The navigation composable modifies the '/ticket' route’s badge logic and reorders/duplicates the route entry. The Telegram bot service updates the success reply flow to send a more descriptive message plus a follow-up containing a web link and access key after removing the keyboard.

Changes

Cohort / File(s) Summary
Navigation routes update
apps/atrium-telegram/app/composables/useNavigation.ts
Changed '/ticket' badge to cap at "10+"; reordered routes causing '/ticket' to appear twice—one with updated badge logic early and another later with original badge.
Telegram bot success messaging
apps/core-telegram/server/services/telegram/atrium-bot.ts
Replaced initial success reply with a more descriptive message and added a second message with Atrium web link and access key, following keyboard removal.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    actor U as User
    participant B as Atrium Bot
    participant TG as Telegram API

    U->>B: Start/complete contact flow
    B->>TG: removeKeyboard()
    Note right of B: Existing behavior retained
    B->>TG: sendMessage("Success: descriptive guidance")
    B->>TG: sendMessage("Web link + access key")
    TG-->>U: Messages delivered
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

I tap my paws on keys so neat,
Two routes for tickets—double treat!
A bot now whispers, “Here’s your key,”
And points you to the web to see.
Carrot links and badges bright—
Shipping changes, hop to night! 🥕✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch telegram-chore

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ecb00ff and 7527e93.

📒 Files selected for processing (2)
  • apps/atrium-telegram/app/composables/useNavigation.ts (2 hunks)
  • apps/core-telegram/server/services/telegram/atrium-bot.ts (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hmbanan666 hmbanan666 merged commit 658cb0f into main Oct 14, 2025
7 of 8 checks passed
@hmbanan666 hmbanan666 deleted the telegram-chore branch October 14, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant