Skip to content

chore: avg data on charts#32

Merged
hmbanan666 merged 3 commits intomainfrom
common-data
Jul 31, 2025
Merged

chore: avg data on charts#32
hmbanan666 merged 3 commits intomainfrom
common-data

Conversation

@hmbanan666
Copy link
Copy Markdown
Collaborator

@hmbanan666 hmbanan666 commented Jul 31, 2025

Summary by CodeRabbit

  • New Features

    • Added a new metrics data source for kitchen finance charts, providing additional fields such as total and average values.
    • Introduced a new API endpoint for retrieving network-wide metrics.
  • Improvements

    • Kitchen finance charts now display enhanced metrics, with common averages and totals sourced from the new metrics data rather than previous values.
    • Extended the default date range for kitchen finance data from 14 to 30 days.
  • Other Changes

    • Removed the "legal" field from partner information.

@hmbanan666 hmbanan666 self-assigned this Jul 31, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jul 31, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce a new metrics data structure across kitchen finance components and update API endpoints and data flow to utilize it. Props and data mapping in Vue components are adjusted to separate metrics from values. A new API endpoint is added for network metrics retrieval, and a column is removed from the partners table schema.

Changes

Cohort / File(s) Change Summary
Kitchen Chart Components
apps/web-app/app/components/chart/KitchenChecks.client.vue, apps/web-app/app/components/chart/KitchenRevenue.client.vue
Updated prop signatures to accept a new metrics array; removed commonAverageCheck and commonTotal from values; data mapping now sources shared values from metrics instead of values.
Kitchen Finance Page
apps/web-app/app/pages/kitchen/[id]/finance.vue
Renamed revenue data variable, added new metrics data source via API, updated chart components to use both values and metrics props, and extended default date range.
Kitchen Revenue API
apps/web-app/server/api/kitchen/revenue/iiko-daily.post.ts
Removed logic for commonAverageCheck and commonTotal; now calculates and uses averageCheck and averageTotal for metrics only; updated data storage logic accordingly.
Network Metrics API
apps/web-app/server/api/network/metrics/index.get.ts
Introduced a new API endpoint to return network metrics via listMetrics() from the database repository.
Database Schema
packages/database/src/tables.ts
Removed the legal column from the partners table definition.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant FinancePage
    participant KitchenRevenueChart
    participant KitchenChecksChart
    participant API_Server
    participant Database

    User->>FinancePage: Load page
    FinancePage->>API_Server: Fetch /api/network/metrics
    API_Server->>Database: Query listMetrics()
    Database-->>API_Server: Return metrics data
    API_Server-->>FinancePage: Return metrics
    FinancePage->>KitchenRevenueChart: Pass values, metrics as props
    FinancePage->>KitchenChecksChart: Pass values, metrics as props
    KitchenRevenueChart->>KitchenRevenueChart: Map data using metrics
    KitchenChecksChart->>KitchenChecksChart: Map data using metrics
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15–20 minutes

Poem

A bunny hopped through metrics new,
With charts and props all split in two.
The kitchen's numbers, fresh and neat,
Now dance with metrics—what a treat!
The legal field has hopped away,
While APIs bring data play.
🥕✨ Hooray for code that’s crisp and bright!

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c982abc and 826b5ad.

📒 Files selected for processing (6)
  • apps/web-app/app/components/chart/KitchenChecks.client.vue (2 hunks)
  • apps/web-app/app/components/chart/KitchenRevenue.client.vue (2 hunks)
  • apps/web-app/app/pages/kitchen/[id]/finance.vue (2 hunks)
  • apps/web-app/server/api/kitchen/revenue/iiko-daily.post.ts (3 hunks)
  • apps/web-app/server/api/network/metrics/index.get.ts (1 hunks)
  • packages/database/src/tables.ts (0 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch common-data

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@hmbanan666 hmbanan666 changed the title Common data chore: avg data on charts Jul 31, 2025
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
13.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@hmbanan666 hmbanan666 merged commit af94778 into main Jul 31, 2025
6 of 7 checks passed
@hmbanan666 hmbanan666 deleted the common-data branch July 31, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant