Redesign integration test matrix without --prefer-lowest#152
Merged
Redesign integration test matrix without --prefer-lowest#152
Conversation
3fec455 to
0ca51b5
Compare
There was a problem hiding this comment.
Pull request overview
This pull request redesigns the integration test matrix by removing the --prefer-lowest testing approach and replacing it with explicit version pinning using X.Y.* constraints. This simplification reduces the number of test runs per matrix file from 2 to 1, while consolidating PHP version ranges within each matrix file rather than splitting them across multiple files.
Changes:
- Removed
--prefer-lowestlogic from the integration test runner script - Consolidated matrix files from 33 to 67 files (more granular version coverage, but simpler per-file structure)
- Updated all matrix files to use
X.Y.*constraints for the primary package being tested and appropriate caret/wildcard constraints for dependencies - Added
--rmflag to docker-compose to prevent orphan containers - Fixed PHP 8.4 implicit nullable deprecation in MigrationsExtension.phpt
Reviewed changes
Copilot reviewed 96 out of 96 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/run-integration.sh | Removed --prefer-lowest test pass and simplified composer_prepare_dependencies function |
| tests/run-in-docker.sh | Added --rm flag to docker-compose run to auto-remove containers |
| tests/matrix/symfony-bundle/*.sh | Added 17 new files (one per Symfony minor version 4.4-8.0), removed 8 old PHP-version-specific files |
| tests/matrix/nette-di/*.sh | Added 4 consolidated files (nette 2.4, 3.0, 3.1, 3.2), removed 6 PHP-version-specific files |
| tests/matrix/dbal/nextras-*.sh | Added 8 version-specific files (1.0-5.0), removed 6 old files |
| tests/matrix/dbal/nette-*.sh | Added 4 version-specific files (2.4, 3.0, 3.1, 3.2), removed 3 old files |
| tests/matrix/dbal/doctrine-*.sh | Added 25 version-specific files (2.5-4.4), removed 6 old files |
| tests/matrix/dbal/dibi-*.sh | Added 8 version-specific files (3.0-5.1), removed 4 old files |
| tests/cases/integration/nette-di/MigrationsExtension.phpt | Fixed PHP 8.4 deprecation by adding explicit nullable type hint |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0ca51b5 to
bcb1899
Compare
…--prefer-lowest Replace --prefer-lowest with explicit X.Y.* constraints per minor version, eliminating PHP version splits and reducing breakage from transitive dependency changes. Each matrix file now tests the latest patch of one specific minor version. Changes: - Remove --prefer-lowest second pass from run-integration.sh - Add --rm to docker-compose run in run-in-docker.sh to fix orphan containers - Fix PHP 8.4 implicit nullable deprecation in MigrationsExtension.phpt - dbal/doctrine: 6 files -> 25 files (2.5-4.4, one per minor) - dbal/nextras: 6 files -> 8 files (1.0-5.0) - dbal/dibi: 4 files -> 8 files (3.0-5.1) - dbal/nette: 3 files -> 4 files (2.4-3.2) - nette-di: 6 files -> 4 files (2.4-3.2) - symfony-bundle: 8 files -> 18 files (4.4, 5.0-5.4, 6.0-6.4, 7.0-7.4, 8.0)
bcb1899 to
6a1d81c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--prefer-lowestsecond test pass fromrun-integration.sh; instead, each matrix file explicitly tests the latest patch of one specific minor version usingX.Y.*constraintsCOMPOSER_REQUIREentries that were only needed for--prefer-lowestcompatibility--rmtodocker-compose runinrun-in-docker.shto prevent orphan containersMigrationsExtension.phptMatrix file changes
Notable findings during testing
${var}string deprecation → capped at PHP 8.1symfony/consolepinned to same minor to prevent resolution to 7.x+ → capped at PHP 8.3 (implicit nullable in framework-bundle on 8.4)yamlmust be pinned to same minor asframework-bundleto prevent cross-major resolutionTest plan
tests/run-in-docker.shon appropriate PHP versions