-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
bugSomething isn't workingSomething isn't workinglinkedin-toolFor the LinkedIn Tool userscriptFor the LinkedIn Tool userscript
Description
There appear to be at least two types of badges:
- For Feed, it is just an alert
- For Notifications, it is a counter
When starting up, we look for the first badge and clone it. And if we end up grabbing a Feed variant, the styling is off and looks ugly (it looks like a donut, we end up with a number followed by a donut).
Also, Feed will not have a badge if that is the starting page. And if there are no notifications, we end up with the badge literally being undefined.
The above is at least true for Style-2 pages, not yet analyzed Style-1.
We used to have a hard-coded icon w/ badge. But with Style-2 pages, they are all compiled class names (hence the switch to cloning). But maybe it is time to see if we can figure out the differences between the two, and how stable they might be.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinglinkedin-toolFor the LinkedIn Tool userscriptFor the LinkedIn Tool userscript