Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nag to cite pipeline in summary #281

Closed
olgabot opened this issue Sep 20, 2019 · 7 comments
Closed

Add nag to cite pipeline in summary #281

olgabot opened this issue Sep 20, 2019 · 7 comments

Comments

@olgabot
Copy link
Contributor

olgabot commented Sep 20, 2019

e.g. from khmer

|| This is the script load-graph.py in khmer.
|| You are running khmer version 2.1.2
|| You are also using screed version 1.0
||
|| If you use this script in a publication, please cite EACH of the following:
||
||   * MR Crusoe et al., 2015. http://dx.doi.org/10.12688/f1000research.6924.1
||   * J Pell et al., http://dx.doi.org/10.1073/pnas.1121464109
||   * A. Döring et al. http://dx.doi.org:80/10.1186/1471-2105-9-11
||
|| Please see http://khmer.readthedocs.io/en/latest/citations.html for details.

Same as nf-core/tools#382 -- could be tried out in this repo first

@apeltzer
Copy link
Member

Yeah, should contain the Zenodo DOI I guess 👍

@apeltzer apeltzer added this to the 1.4 milestone Sep 22, 2019
@apeltzer
Copy link
Member

@nf-core/core Any further thoughts on this? Having a comment/citation in the README.md of each pipeline is a good idea and already adhered by some pipelines. However, if I understand @olgabot here correctly, the suggestion is to also have that in the actual pipeline and output something on the log.info ... when running the pipeline. I think it is a good idea, but that is something that is nowhere present so far...

@drpatelh
Copy link
Member

I guess this is something we could think about when we have machine readable citation format implemented such as suggested here:
nf-core/tools#361

One of the biggest downsides of outputting it in a log.info would be that it could be a very very long list of citations and shouldnt really be mixed in with the pipeline parameters in my opinion...maybe having another parameter such as --cite where we could exclusively output this would be better?

@apeltzer apeltzer removed this from the 1.4 milestone Sep 23, 2019
@ewels
Copy link
Member

ewels commented Sep 23, 2019

shouldn't really be mixed in with the pipeline parameters in my opinion...

Agreed, but you could have it at the end of execution instead.. And in the email / pipeline report. But yeah, could get spammy. Maybe just reference the file that we bundle that has the citations? Then it's always the same length.

Regarding --cite, x-ref nf-core/tools#236 where I suggested basically this but for the command line helper tool.

@olgabot
Copy link
Contributor Author

olgabot commented Oct 1, 2019

I like the idea of putting it in the pipeline report or at the very end as a reminder. People are lazy and won't remember to use the --cite command when they need to cite it, so I believe a spammy nag is necessary.

@apeltzer apeltzer added this to the 1.5 milestone Dec 18, 2019
@drpatelh drpatelh removed this from the 1.5 milestone Aug 19, 2020
@drpatelh drpatelh added this to the 1.5 milestone Sep 16, 2020
@drpatelh
Copy link
Member

drpatelh commented Nov 6, 2020

Fixed in #487

@drpatelh drpatelh closed this as completed Nov 6, 2020
@drpatelh
Copy link
Member

drpatelh commented Nov 6, 2020

image

This will be printed at the end of the summary log info when the pipeline starts up and also when --help is specified. Will add this to the pipeline template when we port the DSL2 changes across.

drpatelh added a commit that referenced this issue Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants