Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ch_dbsnp channel #39

Merged
merged 11 commits into from
Sep 27, 2019
Merged

Fix ch_dbsnp channel #39

merged 11 commits into from
Sep 27, 2019

Conversation

maxulysse
Copy link
Member

  • Fix ch_dbsnp channel which was causing the strangest error ever...
    Issue was mainly due to the fact, that I had hacked the way to use a list of file over HTTP, and it wasn't working well with a regular path.
    It's now fixed, but slightly uglier (and it was already bad...).
    I'll improve all that with the next refactoring.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md

@maxulysse maxulysse merged commit 64d9c10 into nf-core:dev Sep 27, 2019
@maxulysse maxulysse deleted the References branch September 27, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants