Conversation
doctyper
reviewed
Feb 6, 2017
| } | ||
|
|
||
| function mapDomainToAlias(host, domainAliases) { | ||
| if (!isIpAddress(host)) { |
Contributor
There was a problem hiding this comment.
Why is it necessary to test for ip?
Contributor
Author
There was a problem hiding this comment.
IP address is a special case for wildcat. Before we introduced code to do domain aliases we weren't able to resolve them, so the logic in the rest of the function is assuming that the host isn't an IP address. Without this IP address check lines 16-18 bail out and cause tests to fail when you have a valid IP/domainAlias match
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
==========================================
+ Coverage 99.62% 99.92% +0.29%
==========================================
Files 57 38 -19
Lines 1342 1253 -89
Branches 207 205 -2
==========================================
- Hits 1337 1252 -85
+ Misses 5 1 -4Continue to review full report at Codecov.
|
doctyper
approved these changes
Feb 10, 2017
7ec57b5 to
12ff734
Compare
Wildcat would resolve to the wrong domain if domain aliases had a null/undefined value
52c8256 to
21e36f2
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.