Improve diagnostics for ill-formed facade-aware overloads#29
Merged
mingxwa merged 1 commit intongcpp:mainfrom Apr 23, 2026
Merged
Improve diagnostics for ill-formed facade-aware overloads#29mingxwa merged 1 commit intongcpp:mainfrom
mingxwa merged 1 commit intongcpp:mainfrom
Conversation
mingxwa
assigned
tian-lt-personal and
guominrui and unassigned
tian-lt-personal and
guominrui
mingxwa
force-pushed
the
user/mingxwa/ptr-diagnostics
branch
from
a21017b to
dfee995
Compare
mingxwa
changed the title
guominrui
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a facade contains a convention with a facade-aware overload, but the overload is ill-formed when instantiated, the
static_assertinproxycouldn't effectively report the issue. This is because the instantiation of its base classes assumedetails::conv_traitsis applicable.Changes
proxytodetails::conv_traitsto fail earlier.details::conv_traitsanddetails::facade_traitssince they are not used anymore.