Skip to content

Conversation

@resmo
Copy link
Member

@resmo resmo commented Aug 15, 2020

No description provided.

@resmo resmo force-pushed the feature/tests branch 5 times, most recently from acfcf28 to e4e0bc7 Compare August 15, 2020 14:56
@codecov
Copy link

codecov bot commented Aug 15, 2020

Codecov Report

Merging #19 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   84.42%   84.35%   -0.08%     
==========================================
  Files          53       53              
  Lines        5523     5523              
  Branches     1241     1249       +8     
==========================================
- Hits         4663     4659       -4     
- Misses        431      434       +3     
- Partials      429      430       +1     
Impacted Files Coverage Δ
plugins/modules/cs_router.py 61.15% <0.00%> (-0.83%) ⬇️
plugins/modules/cs_instance.py 70.84% <0.00%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12f6714...710e9e6. Read the comment docs.

@resmo resmo force-pushed the feature/tests branch 3 times, most recently from 28a2f57 to af01abe Compare August 15, 2020 15:38
@resmo resmo merged commit 5da55df into master Aug 15, 2020
@resmo resmo deleted the feature/tests branch August 15, 2020 19:44
@felixfontein
Copy link

@resmo you should remove the --python 3.6 part from run: ansible-test sanity --docker -v --color --python 3.6. This forces all sanity tests to run with Python 3.6, and potentially skips tests which do not support 3.6. Also it does not run certain sanity tests with other Python versions (like the import and compile tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants