Skip to content

Conversation

@rvalle
Copy link
Collaborator

@rvalle rvalle commented Dec 3, 2020

typo in cs_ip_address documentation: misleading yaml when assigning custom ID to an IP

@rvalle
Copy link
Collaborator Author

rvalle commented Dec 3, 2020

literally this is a 2 bytes PR
but I lost 4 hours for those 2 bytes today :(

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #48 (1a21f64) into master (8f7aa56) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   84.39%   84.37%   -0.02%     
==========================================
  Files          53       53              
  Lines        5512     5512              
  Branches     1247     1247              
==========================================
- Hits         4652     4651       -1     
- Misses        430      432       +2     
+ Partials      430      429       -1     
Impacted Files Coverage Δ
plugins/modules/cs_ip_address.py 90.00% <ø> (ø)
plugins/module_utils/cloudstack.py 72.58% <0.00%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f7aa56...1a21f64. Read the comment docs.

@resmo resmo merged commit 94653d3 into ngine-io:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants