Skip to content

Conversation

@resmo
Copy link
Member

@resmo resmo commented Aug 11, 2021

Fixes #78
/cc @jdinner if you have a chance to test this, I would appreciate your feedback

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #81 (e3b76f1) into master (d16c15f) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage   84.25%   84.24%   -0.02%     
==========================================
  Files          56       56              
  Lines        5597     5597              
  Branches     1255     1255              
==========================================
- Hits         4716     4715       -1     
  Misses        445      445              
- Partials      436      437       +1     
Impacted Files Coverage Δ
plugins/modules/cs_instance.py 71.52% <0.00%> (ø)
plugins/modules/cs_router.py 61.15% <0.00%> (-0.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d16c15f...e3b76f1. Read the comment docs.

@resmo resmo added the ready label Aug 11, 2021
@resmo resmo force-pushed the feature/cs_instance_mac_ip2network branch from 4ba8a9d to e3b76f1 Compare August 15, 2021 09:32
@resmo resmo merged commit c0e3892 into master Aug 15, 2021
@resmo resmo deleted the feature/cs_instance_mac_ip2network branch August 15, 2021 10:32
@jdinner
Copy link

jdinner commented Aug 17, 2021

Hi, sorry about long delay. Vacation time!
I really like to test it, but I'm not sure how. Should I clone repository into ~/.ansible/collections/ansible_collections/ngine_io/cloudstack? Or something else?
When, after I test it, will be this repaired version in ansible galaxy?

@jdinner
Copy link

jdinner commented Aug 17, 2021

I just tried it this way and it's work as I expected. MAC address is set to right value and SW license works. Thanks! Is it possible to release something like v2.1.1 and push it to ansible-galaxy?

@resmo
Copy link
Member Author

resmo commented Aug 17, 2021

@jdinner great, thanks for your feedback. I'll release v2.2.0 which gets pushed to galaxy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cs_instance - ip_to_networks does not support mac address

3 participants