fix: remove explicit nap version mapping #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickchen
requested review from
Dean-Coakley and
oliveromahony
and removed request for
oliveromahony
yluf5
approved these changes
Nov 9, 2022
wicklander-bryant
approved these changes
Nov 9, 2022
Member
wicklander-bryant
left a comment
wicklander-bryant
left a comment
There was a problem hiding this comment.
LGTM per our discussion offline, thanks Nick 👍
Member
|
Can you do a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
remove the need to create explicit mapping for NAP, instead will use the version found in the version file for symlink
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentREADME.md)