Skip to content

fix: use lower case for all severity values #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2022
Merged

fix: use lower case for all severity values #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/extensions/nginx-app-protect/monitoring/processor/nap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ func setValue(napConfig *NAPConfig, key, value string, logger *logrus.Entry) err
case requestStatus:
napConfig.RequestStatus = value
case severity:
napConfig.Severity = value
napConfig.Severity = strings.ToLower(value)
case sigSetNames:
napConfig.SigSetNames = replaceEncodedList(value, listSeperator)
case threatCampaignNames:
Expand Down
4 changes: 2 additions & 2 deletions test/component/nginx-app-protect/monitoring/testData/events-out/expanded_nap_waf.log.txt.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@

j
Agent$c9f9fc06-6071-11ed-8415-5671f551701b4355056874564592513" ת������*ERROR2Nginx:
Agent$638d54bc-6135-11ed-8afe-5671f551701b4355056874564592513" ��������*ERROR2Nginx:
AppProtect�
app_protect_default_policy4355056874564592513REJECTED"SECURITY_WAF_VIOLATION*N/A2GET:HTTPBN/AJ/RHTTP/1.1bblockedjBlockedz1-localhost:1-/� 127.0.0.1�61478�80��HTTP protocol compliance failed,Illegal meta character in value,Attack signature detected,Violation Rating Threat detected,Bot Client Detected�?HTTP protocol compliance failed:Host header contains IP address�5�u{Cross Site Scripting Signatures;High Accuracy Signatures},{Cross Site Scripting Signatures;High Accuracy Signatures}�,�Untrusted Bot�N/A�N/A�Critical�N/A�N/A� HTTP Library�N/A�curl� parameter�u
app_protect_default_policy4355056874564592513REJECTED"SECURITY_WAF_VIOLATION*N/A2GET:HTTPBN/AJ/RHTTP/1.1bblockedjBlockedz1-localhost:1-/� 127.0.0.1�61478�80��HTTP protocol compliance failed,Illegal meta character in value,Attack signature detected,Violation Rating Threat detected,Bot Client Detected�?HTTP protocol compliance failed:Host header contains IP address�5�u{Cross Site Scripting Signatures;High Accuracy Signatures},{Cross Site Scripting Signatures;High Accuracy Signatures}�,�Untrusted Bot�N/A�N/A�critical�N/A�N/A� HTTP Library�N/A�curl� parameter�u
VIOL_ATTACK_SIGNATURE parameter
a<script>"
2000014753
Expand Down
4 changes: 2 additions & 2 deletions test/component/nginx-app-protect/monitoring/testData/events-out/xml_header_data.log.txt.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

j
Agent$cff2dc2c-6071-11ed-8415-5671f551701b4355056874564592514" ᪰��̈�*ERROR2Nginx:
Agent$6986d064-6135-11ed-8afe-5671f551701b4355056874564592514" ��������*ERROR2Nginx:
AppProtect�
app_protect_default_policy4355056874564592514REJECTED"SECURITY_WAF_VIOLATION*N/A2GET:HTTPBN/AJ/R^GET /?a=<script> HTTP/1.1\r\nHost: 127.0.0.1\r\nUser-Agent: curl/7.64.1\r\nAccept: */*\r\n\r\nbblockedjBlockedz1-localhost:1-/� 127.0.0.1�61478�80��HTTP protocol compliance failed,Illegal meta character in value,Attack signature detected,Violation Rating Threat detected,Bot Client Detected�?HTTP protocol compliance failed:Host header contains IP address�5�u{Cross Site Scripting Signatures;High Accuracy Signatures},{Cross Site Scripting Signatures;High Accuracy Signatures}�,�Untrusted Bot�N/A�N/A�Critical�N/A�N/A� HTTP Library�N/A�curl�header�6
app_protect_default_policy4355056874564592514REJECTED"SECURITY_WAF_VIOLATION*N/A2GET:HTTPBN/AJ/R^GET /?a=<script> HTTP/1.1\r\nHost: 127.0.0.1\r\nUser-Agent: curl/7.64.1\r\nAccept: */*\r\n\r\nbblockedjBlockedz1-localhost:1-/� 127.0.0.1�61478�80��HTTP protocol compliance failed,Illegal meta character in value,Attack signature detected,Violation Rating Threat detected,Bot Client Detected�?HTTP protocol compliance failed:Host header contains IP address�5�u{Cross Site Scripting Signatures;High Accuracy Signatures},{Cross Site Scripting Signatures;High Accuracy Signatures}�,�Untrusted Bot�N/A�N/A�critical�N/A�N/A� HTTP Library�N/A�curl�header�6
VIOL_ATTACK_SIGNATUREheader
Fooecho<!-- #echo
Expand Down
4 changes: 2 additions & 2 deletions ...component/nginx-app-protect/monitoring/testData/events-out/xml_parameter_data.log.txt.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

j
Agent$cc5dd738-6071-11ed-8415-5671f551701b4355056874564592515" ۪������*ERROR2Nginx:
Agent$65f12080-6135-11ed-8afe-5671f551701b4355056874564592515" ��������*ERROR2Nginx:
AppProtect�
app_protect_default_policy4355056874564592515REJECTED"SECURITY_WAF_VIOLATION*N/A2GET:HTTPBN/AJ/R^GET /?a=<script> HTTP/1.1\r\nHost: 127.0.0.1\r\nUser-Agent: curl/7.64.1\r\nAccept: */*\r\n\r\nbblockedjBlockedz1-localhost:1-/� 127.0.0.1�61478�80��HTTP protocol compliance failed,Illegal meta character in value,Attack signature detected,Violation Rating Threat detected,Bot Client Detected�?HTTP protocol compliance failed:Host header contains IP address�5�u{Cross Site Scripting Signatures;High Accuracy Signatures},{Cross Site Scripting Signatures;High Accuracy Signatures}�,�Untrusted Bot�N/A�N/A�Critical�N/A�N/A� HTTP Library�N/A�curl� parameter�`
app_protect_default_policy4355056874564592515REJECTED"SECURITY_WAF_VIOLATION*N/A2GET:HTTPBN/AJ/R^GET /?a=<script> HTTP/1.1\r\nHost: 127.0.0.1\r\nUser-Agent: curl/7.64.1\r\nAccept: */*\r\n\r\nbblockedjBlockedz1-localhost:1-/� 127.0.0.1�61478�80��HTTP protocol compliance failed,Illegal meta character in value,Attack signature detected,Violation Rating Threat detected,Bot Client Detected�?HTTP protocol compliance failed:Host header contains IP address�5�u{Cross Site Scripting Signatures;High Accuracy Signatures},{Cross Site Scripting Signatures;High Accuracy Signatures}�,�Untrusted Bot�N/A�N/A�critical�N/A�N/A� HTTP Library�N/A�curl� parameter�`
VIOL_ATTACK_SIGNATURE parameterf5paramautotest>"(
3000001107=f5paramautotest>"1*15
Expand Down
4 changes: 2 additions & 2 deletions ...x-app-protect/monitoring/testData/events-out/xml_parameter_data_as_param_data.log.txt.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

j
Agent$cec1156c-6071-11ed-8415-5671f551701b4355056874564592516" ߪ������*ERROR2Nginx:
Agent$6854ee9c-6135-11ed-8afe-5671f551701b4355056874564592516" ��������*ERROR2Nginx:
AppProtect�
app_protect_default_policy4355056874564592516REJECTED"SECURITY_WAF_VIOLATION*N/A2GET:HTTPBN/AJ/R^GET /?a=<script> HTTP/1.1\r\nHost: 127.0.0.1\r\nUser-Agent: curl/7.64.1\r\nAccept: */*\r\n\r\nbblockedjBlockedz1-localhost:1-/� 127.0.0.1�61478�80��HTTP protocol compliance failed,Illegal meta character in value,Attack signature detected,Violation Rating Threat detected,Bot Client Detected�?HTTP protocol compliance failed:Host header contains IP address�5�u{Cross Site Scripting Signatures;High Accuracy Signatures},{Cross Site Scripting Signatures;High Accuracy Signatures}�,�Untrusted Bot�N/A�N/A�Critical�N/A�N/A� HTTP Library�N/A�curl� parameter�6
app_protect_default_policy4355056874564592516REJECTED"SECURITY_WAF_VIOLATION*N/A2GET:HTTPBN/AJ/R^GET /?a=<script> HTTP/1.1\r\nHost: 127.0.0.1\r\nUser-Agent: curl/7.64.1\r\nAccept: */*\r\n\r\nbblockedjBlockedz1-localhost:1-/� 127.0.0.1�61478�80��HTTP protocol compliance failed,Illegal meta character in value,Attack signature detected,Violation Rating Threat detected,Bot Client Detected�?HTTP protocol compliance failed:Host header contains IP address�5�u{Cross Site Scripting Signatures;High Accuracy Signatures},{Cross Site Scripting Signatures;High Accuracy Signatures}�,�Untrusted Bot�N/A�N/A�critical�N/A�N/A� HTTP Library�N/A�curl� parameter�6
VIOL_JSON_MALFORMED parameter
json { "a": "��"}
Expand Down
4 changes: 2 additions & 2 deletions ...x-app-protect/monitoring/testData/events-out/xml_parameter_data_empty_context.log.txt.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@

j
Agent$cd8f6360-6071-11ed-8415-5671f551701b4355056874564592517" ݪ������*ERROR2Nginx:
Agent$672307c0-6135-11ed-8afe-5671f551701b4355056874564592517" �����Ք�*ERROR2Nginx:
AppProtect�
app_protect_default_policy4355056874564592517REJECTED"SECURITY_WAF_VIOLATION*N/A2GET:HTTPBN/AJ/R^GET /?a=<script> HTTP/1.1\r\nHost: 127.0.0.1\r\nUser-Agent: curl/7.64.1\r\nAccept: */*\r\n\r\nbblockedjBlockedz1-localhost:1-/� 127.0.0.1�61478�80��HTTP protocol compliance failed,Illegal meta character in value,Attack signature detected,Violation Rating Threat detected,Bot Client Detected�?HTTP protocol compliance failed:Host header contains IP address�5�u{Cross Site Scripting Signatures;High Accuracy Signatures},{Cross Site Scripting Signatures;High Accuracy Signatures}�,�Untrusted Bot�N/A�N/A�Critical�N/A�N/A� HTTP Library�N/A�curl�
app_protect_default_policy4355056874564592517REJECTED"SECURITY_WAF_VIOLATION*N/A2GET:HTTPBN/AJ/R^GET /?a=<script> HTTP/1.1\r\nHost: 127.0.0.1\r\nUser-Agent: curl/7.64.1\r\nAccept: */*\r\n\r\nbblockedjBlockedz1-localhost:1-/� 127.0.0.1�61478�80��HTTP protocol compliance failed,Illegal meta character in value,Attack signature detected,Violation Rating Threat detected,Bot Client Detected�?HTTP protocol compliance failed:Host header contains IP address�5�u{Cross Site Scripting Signatures;High Accuracy Signatures},{Cross Site Scripting Signatures;High Accuracy Signatures}�,�Untrusted Bot�N/A�N/A�critical�N/A�N/A� HTTP Library�N/A�curl�
VIOL_PARAMETER
x1�
VIOL_PARAMETER
Expand Down
4 changes: 2 additions & 2 deletions ...component/nginx-app-protect/monitoring/testData/events-out/xml_signature_data.log.txt.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@

j
Agent$d124a6ac-6071-11ed-8415-5671f551701b4355056874564592518" 㪰�����*ERROR2Nginx:
Agent$6ab883d8-6135-11ed-8afe-5671f551701b4355056874564592518" ��������*ERROR2Nginx:
AppProtect�
app_protect_default_policy4355056874564592518REJECTED"SECURITY_WAF_VIOLATION*N/A2GET:HTTPBN/AJ/R^GET /?a=<script> HTTP/1.1\r\nHost: 127.0.0.1\r\nUser-Agent: curl/7.64.1\r\nAccept: */*\r\n\r\nbblockedjBlockedz1-localhost:1-/� 127.0.0.1�61478�80��HTTP protocol compliance failed,Illegal meta character in value,Attack signature detected,Violation Rating Threat detected,Bot Client Detected�?HTTP protocol compliance failed:Host header contains IP address�5�u{Cross Site Scripting Signatures;High Accuracy Signatures},{Cross Site Scripting Signatures;High Accuracy Signatures}�,�Untrusted Bot�N/A�N/A�Critical�N/A�N/A� HTTP Library�N/A�curl��
app_protect_default_policy4355056874564592518REJECTED"SECURITY_WAF_VIOLATION*N/A2GET:HTTPBN/AJ/R^GET /?a=<script> HTTP/1.1\r\nHost: 127.0.0.1\r\nUser-Agent: curl/7.64.1\r\nAccept: */*\r\n\r\nbblockedjBlockedz1-localhost:1-/� 127.0.0.1�61478�80��HTTP protocol compliance failed,Illegal meta character in value,Attack signature detected,Violation Rating Threat detected,Bot Client Detected�?HTTP protocol compliance failed:Host header contains IP address�5�u{Cross Site Scripting Signatures;High Accuracy Signatures},{Cross Site Scripting Signatures;High Accuracy Signatures}�,�Untrusted Bot�N/A�N/A�critical�N/A�N/A� HTTP Library�N/A�curl��
VIOL_ATTACK_SIGNATURE"�
2000210944�Connection: keep-alive
Host: a.com
Expand Down
4 changes: 2 additions & 2 deletions ...component/nginx-app-protect/monitoring/testData/events-out/xml_violation_name.log.txt.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@

j
Agent$cb2bd36a-6071-11ed-8415-5671f551701b4355056874564592519" ٪������*ERROR2Nginx:
Agent$64bf3aa8-6135-11ed-8afe-5671f551701b4355056874564592519" ��������*ERROR2Nginx:
AppProtect�
app_protect_default_policy4355056874564592519REJECTED"SECURITY_WAF_VIOLATION*N/A2GET:HTTPBN/AJ/R^GET /?a=<script> HTTP/1.1\r\nHost: 127.0.0.1\r\nUser-Agent: curl/7.64.1\r\nAccept: */*\r\n\r\nbblockedjBlockedz1-localhost:1-/� 127.0.0.1�61478�80��HTTP protocol compliance failed,Illegal meta character in value,Attack signature detected,Violation Rating Threat detected,Bot Client Detected�?HTTP protocol compliance failed:Host header contains IP address�5�u{Cross Site Scripting Signatures;High Accuracy Signatures},{Cross Site Scripting Signatures;High Accuracy Signatures}�,�Untrusted Bot�N/A�N/A�Critical�N/A�N/A� HTTP Library�N/A�curl�
app_protect_default_policy4355056874564592519REJECTED"SECURITY_WAF_VIOLATION*N/A2GET:HTTPBN/AJ/R^GET /?a=<script> HTTP/1.1\r\nHost: 127.0.0.1\r\nUser-Agent: curl/7.64.1\r\nAccept: */*\r\n\r\nbblockedjBlockedz1-localhost:1-/� 127.0.0.1�61478�80��HTTP protocol compliance failed,Illegal meta character in value,Attack signature detected,Violation Rating Threat detected,Bot Client Detected�?HTTP protocol compliance failed:Host header contains IP address�5�u{Cross Site Scripting Signatures;High Accuracy Signatures},{Cross Site Scripting Signatures;High Accuracy Signatures}�,�Untrusted Bot�N/A�N/A�critical�N/A�N/A� HTTP Library�N/A�curl�
VIOL_ASM_COOKIE_MODIFIED�
VIOL_ASM_COOKIE_MODIFIED�
VIOL_ASM_COOKIE_MODIFIED�
Expand Down