Ignore Access Log in metrics collection if Formats differ #1097
Merged
Conversation
sean-breen
reviewed
May 29, 2025
dhurley
approved these changes
May 29, 2025
craigell
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
When more than one log format is specified for a access log in the nginx config, otel panics trying to monitor the same log with two different formats.
If its the same access log read from the config but the format is different the following will be logged as a Warning:
time=2025-05-29T10:01:49.448Z level=WARN msg="Found duplicate access log with different formats. Multiple log formats are not supported in the same access log, will not be collected" access_log=/var/log/nginx/access.logIf its the same access log read from the config but with the same format the following will be logged in Debug:
time=2025-05-29T10:04:07.231Z level=DEBUG msg="Found duplicate access log, skipping" access_log=/var/log/nginx/access.logChecklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)