Skip to content

Conversation

@aphralG
Copy link
Contributor

@aphralG aphralG commented Nov 18, 2022

Proposed changes

Add REST endpoints for metrics.

  • Added prometheus exporter extension
  • Moved metric calculation map from aggregate.go to metrics_util.go

To Do

  • Unit Tests
  • Component Tests

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@aphralG aphralG self-assigned this Nov 18, 2022
@github-actions github-actions bot added dependencies documentation Improvements or additions to documentation labels Nov 18, 2022
@aphralG aphralG changed the title Metrics rest endpoint Draft: Metrics rest endpoint Nov 18, 2022
@dhurley dhurley changed the title Draft: Metrics rest endpoint Metrics rest endpoint Nov 22, 2022
@dhurley dhurley marked this pull request as ready for review November 22, 2022 13:33
@dhurley dhurley added enhancement New feature or request and removed documentation Improvements or additions to documentation dependencies labels Nov 22, 2022
@github-actions github-actions bot added dependencies documentation Improvements or additions to documentation labels Nov 22, 2022
Comment on lines 81 to 84
} else {
return prometheus.GaugeValue
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
} else {
return prometheus.GaugeValue
}
}

@aphralG aphralG merged commit f0ec84d into main Nov 28, 2022
@oliveromahony oliveromahony deleted the metrics-rest-endpoint branch November 28, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants