Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/proto/events/event.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@ func TestPublisher(t *testing.T) {
expectedMetrics []*MetricSet
dimensionsLookups map[int]map[int]string
}{
{
name: "no metric with no dimension",
schema: schema.NewSchema([]*schema.Field{}...),
samples: map[string]*sample.Sample{},
dimensionsLookups: map[int]map[int]string{},
expectedMetrics: []*MetricSet{},
},
{
name: "single metric with single dimension",
schema: schema.NewSchema([]*schema.Field{
Expand Down
5 changes: 4 additions & 1 deletion src/plugins/advanced_metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,10 @@ func (m *AdvancedMetrics) run() {
return
}
now := types.TimestampNow()
m.pipeline.Process(core.NewMessage(core.CommMetrics, []core.Payload{toMetricReport(mr, now, commonDimensions)}))
report := toMetricReport(mr, now, commonDimensions)
if len(report.Data) != 0 {
m.pipeline.Process(core.NewMessage(core.CommMetrics, []core.Payload{report}))
}
case <-m.pipeline.Context().Done():
return
}
Expand Down
2 changes: 1 addition & 1 deletion test/component/advanced_metrics_component_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ var (
)

func init() {
logrus.SetLevel(logrus.DebugLevel)
logrus.SetLevel(logrus.TraceLevel)
}

// TestAdvancedMetricsSimple this is simple test which presents basic logic of advanced_metrics module
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.