Skip to content

Conversation

@nickchen
Copy link

@nickchen nickchen commented Dec 9, 2022

Proposed changes

In proc, if the process symlink path has (deleted), it's an indication that the process was deleted. Since we already have binary change detection, this change deletes the "deleted" in the exec path, and trim out the "deleted" so the exec path is valid for the original binary, which could have an updated binary.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@netlify
Copy link

netlify bot commented Dec 9, 2022

Deploy Preview for agent-public-docs failed.

Name Link
🔨 Latest commit 73b728ba496b26cad759c2db7605c91ac017e97e
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/6393958b28bcb9000926219e

@github-actions github-actions bot added bug Something isn't working documentation Improvements or additions to documentation labels Dec 9, 2022
@nickchen nickchen changed the base branch from main to release-2.20.0 December 9, 2022 20:08
@yluf5
Copy link

yluf5 commented Dec 10, 2022

I have tested the NAP upgrade case with this change and verified that it works.

@dhurley
Copy link
Collaborator

dhurley commented Dec 12, 2022

Could you add a unit test for this?
Also could you run make deps as well?

@nickchen
Copy link
Author

Could you add a unit test for this? Also could you run make deps as well?

done, added tests for sanitize function, did not expand the scope since it looks like require other setups.

@oliveromahony oliveromahony merged commit b50facc into release-2.20.0 Dec 12, 2022
@oliveromahony oliveromahony deleted the nginx-delete-detect branch December 12, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants