add logs for external file download#1577
Merged
valyria257 merged 3 commits intonginx:mainfrom Apr 7, 2026
Merged
Conversation
Contributor
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1577 +/- ##
==========================================
+ Coverage 85.05% 85.07% +0.01%
==========================================
Files 105 105
Lines 13680 13691 +11
==========================================
+ Hits 11636 11647 +11
Misses 1529 1529
Partials 515 515
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
Author
|
I have hereby read the F5 CLA and agree to its terms. |
valyria257
reviewed
Mar 30, 2026
7b3317d to
f00237a
Compare
Contributor
Author
|
recheck |
d5f9118 to
174dcf7
Compare
Contributor
Author
|
I have hereby read the F5 CLA and agree to its terms |
Contributor
Author
|
recheck |
e1c4663 to
e9c746e
Compare
valyria257
reviewed
Mar 31, 2026
4948cf3 to
e6ec6db
Compare
Akshay2191
approved these changes
Apr 7, 2026
Use commit SHA instead of branch name when checking out PR code. This fixes the checkout error for PRs from forks where the branch doesn't exist in the upstream repository.
valyria257
approved these changes
Apr 7, 2026
0039a6b to
9e460e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds logs for external file downloads. These are needed on the NGINXaaS side to generate events.
Agent V3 currently does log errors caused by failed file downloads, e.g.
apply error: failed to download file /etc/nginx/mycert.cert from projects/900024435491/secrets/valyria-secret/versions/latest: download failed with status code 401: no workload identity pool provider specifiedWith this current change, any download errors will also be logged with a standard failure message to be parsed by NGINXaaS:
2026-04-01T10:15:32.123Z ERROR Failed to download external file event_tag=ID-1310 location=http://naasproxy:49152/google_secret_manager/projects%2F219735614622%2Fsecrets%2Fvxu-key%2Fversions%2F1 err="connection timed out"Additionally, a success log is added, to be parsed by NGINXaaS:
2026-04-01T10:15:33.456Z INFO Successfully downloaded external file event_tag=ID-1310 location=http://naasproxy:49152/google_secret_manager/projects%2F219735614622%2Fsecrets%2Fvxu-key%2Fversions%2F1 hash=a3f5b8c9d2e1f4a7b6c5d8e9f1a2b3c4d5e6f7a8b9c0d1e2f3a4b5c6d7e8f9a0No existing logs have been changed.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)