fix: Handle case when NAP metadata doesn't exist #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When processing NAP metadata for potential changes, the case when the NAP metadata doesn't exist wasn't handled. Added unit test too.
✅ Deploy Preview for agent-public-docs canceled.
|
oliveromahony
approved these changes
Jan 18, 2023
dhurley
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing NAP metadata for potential changes, the case when the NAP metadata doesn't exist wasn't handled.
Added unit test too.
Proposed changes
Fix: Don't return an error when the
app_protect_metadata.jsonfile doesn't exist, continue processing to create the file.Added a unit test to verify fix.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentREADME.md)