Skip to content

feat: new NMS ACM dimensions for advanced metrics #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2022
Merged

feat: new NMS ACM dimensions for advanced metrics #24

merged 1 commit into from
Sep 2, 2022

Conversation

@vrmare
Copy link

@vrmare vrmare commented Aug 29, 2022 •
edited
Loading

Proposed changes

This change introduces new dimensions needed to support NMS ACM module advanced metrics.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • [x ] I have read the CONTRIBUTING document
  • [x ] If applicable, I have added tests that prove my fix is effective or that my feature works
  • [ x] If applicable, I have checked that any relevant tests pass after adding my changes
  • [ x] I have updated any relevant documentation (README.md)

@vrmare vrmare self-assigned this Aug 29, 2022
@github-actions github-actions bot added the enhancement New feature or request label Aug 29, 2022
@vrmare vrmare force-pushed the nms-acm-new-dimensions branch from 87c1d5d to d48a156 Compare August 29, 2022 20:44
sanathkumarbs
sanathkumarbs approved these changes Aug 30, 2022
View reviewed changes
Copy link

@sanathkumarbs sanathkumarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vrmare vrmare force-pushed the nms-acm-new-dimensions branch from d48a156 to db749ed Compare September 2, 2022 00:00
@vrmare vrmare force-pushed the nms-acm-new-dimensions branch from db749ed to 1e6f46e Compare September 2, 2022 14:57
@oliveromahony oliveromahony merged commit a51d3d8 into main Sep 2, 2022
@oliveromahony oliveromahony deleted the nms-acm-new-dimensions branch September 2, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aphralG aphralG Awaiting requested review from aphralG

@craigell craigell Awaiting requested review from craigell

@dhurley dhurley Awaiting requested review from dhurley

3 more reviewers

@oliveromahony oliveromahony oliveromahony approved these changes

@nickchen nickchen nickchen approved these changes

@sanathkumarbs sanathkumarbs sanathkumarbs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vrmare vrmare

Labels

dependencies enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vrmare @oliveromahony @nickchen @sanathkumarbs