Skip to content

Conversation

@nkashiv
Copy link

@nkashiv nkashiv commented Sep 1, 2022

Proposed changes

Agent decides if nginx configs can be uploaded based on the features enabled in the agent's config. The config will be uploaded if the "nginx-config" feature is enabled.

All the features have been added to the default agent config.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@github-actions github-actions bot added dependencies enhancement New feature or request labels Sep 1, 2022
@nkashiv nkashiv changed the title wip: feat: Upload nginx configs if nginx-config feature is enabled feat: Upload nginx configs if nginx-config feature is enabled Sep 2, 2022
@oliveromahony
Copy link
Contributor

Can you run a make deps on the root of the project?

@oliveromahony oliveromahony merged commit 68783dd into main Sep 7, 2022
@oliveromahony oliveromahony deleted the upload-config branch September 7, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants