Skip to content

Updated DataplaneStatus to include new field AgentActivityStatus #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 19, 2022
Merged

Updated DataplaneStatus to include new field AgentActivityStatus #53

merged 5 commits into from
Oct 19, 2022

Conversation

@dhurley
Copy link
Collaborator

@dhurley dhurley commented Sep 26, 2022 •
edited
Loading

Proposed changes

Updated the DataplaneStatus message to include new field AgentActivityStatus.
The AgentActivityStatus message will include details of what stage a nginx config apply is at (e.g., pending, success, failed, etc).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@dhurley dhurley added the chore Pull requests for routine tasks label Sep 26, 2022
nickchen
nickchen reviewed Sep 26, 2022
View reviewed changes
nickchen
nickchen reviewed Sep 26, 2022
View reviewed changes
nickchen
nickchen suggested changes Sep 26, 2022
View reviewed changes
Copy link

@nickchen nickchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor change needed.

@nickchen
Copy link

nickchen commented Oct 19, 2022

LGTM

@dhurley dhurley requested a review from nickchen October 19, 2022 16:11
@dhurley dhurley merged commit e31e506 into main Oct 19, 2022
@dhurley dhurley deleted the update-dataplane-status-with-agent-activity-status branch October 19, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aphralG aphralG aphralG approved these changes

@oliveromahony oliveromahony Awaiting requested review from oliveromahony

@craigell craigell Awaiting requested review from craigell

+2 more reviewers

@nickchen nickchen nickchen approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dhurley dhurley

Labels

chore Pull requests for routine tasks dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dhurley @nickchen @Dean-Coakley @aphralG