Use SIGQUIT instead of SIGTERM for graceful shutdown of nginx #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been discussed a few times, however it was vetoed due to https://trac.nginx.org/nginx/ticket/753. This issue has been fixed in |
thresheek
pushed a commit
that referenced
this pull request
Nov 24, 2020
Member
|
I have merged this change in 3fb70dd, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #377
Replace stopsignal SIGTERM with SIGQUIT to ensure a graceful shutdown.
Tested each changed Dockerfile using the Dockerfile provided by @nottrobin in #337.