Skip to content

Conversation

@AlexFenlon
Copy link
Contributor

Proposed changes

Add a notice to custom OIDC doc in NIC that it only works in previous versions.

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content.

@AlexFenlon AlexFenlon requested a review from a team as a code owner December 16, 2025 14:58
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nic Issues related to NGINX Ingress Controller labels Dec 16, 2025
@github-actions
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/1583/

@JTorreG JTorreG merged commit ecbc5b3 into main Dec 16, 2025
8 checks passed
@JTorreG JTorreG deleted the nic/oidc-notice branch December 16, 2025 15:05
Copy link
Member

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though it could probably be rephrased.

I assume this use case has been "deprecated" due to the native NGINX OIDC module.

I would change the notice to say something along the lines of:

"This guide is only necessary for NGINX Ingress Controller versions x or earlier. To use OIDC with newer NGINX Ingress Controller versions, please view the XYZ topic".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation product/nic Issues related to NGINX Ingress Controller

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants