Skip to content

Removed unneeded e2e tests + improved GH action #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lamATnginx merged 5 commits into from
Dec 19, 2025
Merged

Removed unneeded e2e tests + improved GH action #1596

lamATnginx merged 5 commits into from
Dec 19, 2025
+87 −171

Conversation

@lamATnginx
Copy link
Contributor

@lamATnginx lamATnginx commented Dec 17, 2025

Proposed changes

  • Improved the performance of the github action and changed its triggers.
  • Removed redundant e2e tests. Should act as a smoke tests that certain critical elements appear.

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩

@lamATnginx lamATnginx self-assigned this Dec 17, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner December 17, 2025 20:54
@lamATnginx lamATnginx added the bug Something isn't working label Dec 17, 2025
@github-actions github-actions bot added the tooling Back end, repository, Hugo, and all things not related to content label Dec 17, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 17, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Dec 17, 2025

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/1596/

@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginxaas-azure Issues related to NGINX as a Service for Azure labels Dec 17, 2025
@lamATnginx lamATnginx force-pushed the fix/playwright-n4a-calc-test branch from 1b02139 to 88e269d Compare December 17, 2025 21:02
@lamATnginx lamATnginx force-pushed the fix/playwright-n4a-calc-test branch from 88e269d to cdd38a4 Compare December 17, 2025 21:03
@lamATnginx lamATnginx force-pushed the fix/playwright-n4a-calc-test branch from 050a724 to 4de4063 Compare December 17, 2025 21:10
TasoOneAsia
TasoOneAsia reviewed Dec 17, 2025
View reviewed changes
@lamATnginx lamATnginx merged commit e041721 into main Dec 19, 2025
9 checks passed
@lamATnginx lamATnginx deleted the fix/playwright-n4a-calc-test branch December 19, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TasoOneAsia TasoOneAsia TasoOneAsia approved these changes

@nginx-jack nginx-jack nginx-jack approved these changes

Assignees

@lamATnginx lamATnginx

Labels

bug Something isn't working documentation Improvements or additions to documentation product/nginxaas-azure Issues related to NGINX as a Service for Azure tooling Back end, repository, Hugo, and all things not related to content

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lamATnginx @TasoOneAsia @nginx-jack @ADubhlaoich