NGF: Pin sample model server manifest version#1846
Merged
bjee19 merged 3 commits intonginx:mainfrom Apr 13, 2026
Merged
Conversation
github-actions
bot
added
documentation
salonichf5
approved these changes
Apr 10, 2026
ciarams87
approved these changes
Apr 13, 2026
sjberman
reviewed
Apr 13, 2026
Contributor
|
Is there anything else that needs to be changed? Since the model has changed, are we using the old model name anywhere else? |
Contributor
Author
|
@sjberman I meant this PR to just be a quick fix to the issue, so we'd still be using the old model. This is just a bandaid to get the official nginx guide to work. Sorry not sure if you'd still like there to be any other changes. |
Contributor
|
Oh understood, thanks. |
sjberman
approved these changes
Apr 13, 2026
JTorreG
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Underlying model server has changed in the latest version of that manifest file causing our guide to not work. Until we update our guide to more closely match their guide, pinning to the version when this guide was created should ensure things stay working.