Skip to content

add docs for google secret rotation#1996

Merged
mjang merged 2 commits into
nginx:mainfrom
vivki:gcp-docs
May 28, 2026
Merged

add docs for google secret rotation#1996
mjang merged 2 commits into
nginx:mainfrom
vivki:gcp-docs

Conversation

@vivki
Copy link
Copy Markdown
Contributor

@vivki vivki commented May 26, 2026

Proposed changes

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content.

@vivki vivki requested a review from a team as a code owner May 26, 2026 20:47
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label May 26, 2026
Comment thread content/nginxaas-google/getting-started/ssl-tls-certificates/overview.md Outdated
Comment thread content/nginxaas-google/getting-started/ssl-tls-certificates/overview.md Outdated
Comment thread content/nginxaas-google/getting-started/ssl-tls-certificates/overview.md Outdated
Comment thread content/nginxaas-google/getting-started/ssl-tls-certificates/overview.md Outdated
Copy link
Copy Markdown
Contributor

@JTorreG JTorreG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with suggestions

Copy link
Copy Markdown
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more comments

Comment thread content/nginxaas-google/getting-started/ssl-tls-certificates/overview.md Outdated
Comment thread content/nginxaas-google/getting-started/ssl-tls-certificates/overview.md Outdated
Comment thread content/nginxaas-google/getting-started/ssl-tls-certificates/overview.md Outdated
Comment thread content/nginxaas-google/getting-started/ssl-tls-certificates/overview.md Outdated
Comment thread content/nginxaas-google/getting-started/ssl-tls-certificates/overview.md Outdated
@vivki vivki force-pushed the gcp-docs branch 3 times, most recently from 94a4946 to 1e22dce Compare May 27, 2026 00:02
Copy link
Copy Markdown
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting @tstraley 's approval before merging

@vivki vivki force-pushed the gcp-docs branch 4 times, most recently from 83fa697 to 07cd4ee Compare May 27, 2026 19:06
Comment thread content/nginxaas-google/getting-started/ssl-tls-certificates/overview.md Outdated
Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>
Co-authored-by: Mike Jang <mi.jang@f5.com>
@mjang
Copy link
Copy Markdown
Contributor

mjang commented May 28, 2026

Everyone whose commented has approved. I don't see any limitations, such as "waiting for a release", so I'm proceeding with merge.

@mjang mjang merged commit 4661f77 into nginx:main May 28, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants