skip pr for get id token step #4813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for nginx-kubernetes-ingress pending review.Visit the deploys page to approve it
|
vepatel
approved these changes
Dec 18, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4813 +/- ##
==========================================
+ Coverage 52.01% 52.03% +0.02%
==========================================
Files 60 60
Lines 17313 17313
==========================================
+ Hits 9005 9009 +4
+ Misses 7995 7993 -2
+ Partials 313 311 -2 ☔ View full report in Codecov by Sentry. |
j1m-ryan
pushed a commit
to j1m-ryan/kubernetes-ingress
that referenced
this pull request
Dec 18, 2023
j1m-ryan
pushed a commit
that referenced
this pull request
Dec 18, 2023
* automate kindest/node versions (#4798) * automate kindest/node versions * fix typo * test github action * undo temporary test * exclude versions not in the form vX.Y.Z, eg alpha versions * update k8s_latest origin * trim the version from the start of the string * skip pr for get id token step (#4813)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes pipeline issue on PRs where the
Get Id tokenstep in thebuild-plus.ymlworkflow was failing. This fix works by avoiding this step on PRsChecklist
Before creating a PR, run through this checklist and mark each as complete.