Skip to content

treat forked_workflow as a string in ci.yml #5131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2024
Merged

treat forked_workflow as a string in ci.yml #5131

merged 2 commits into from
Feb 20, 2024

Conversation

@pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Feb 20, 2024 •
edited
Loading

Proposed changes

Address variable forked_workflow not being interpreted as a boolean

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner February 20, 2024 15:24
@pdabelf5 pdabelf5 merged commit d1af6c5 into main Feb 20, 2024
@pdabelf5 pdabelf5 deleted the ci-fix branch February 20, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vepatel vepatel vepatel approved these changes

+1 more reviewer

@oseoin oseoin oseoin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pdabelf5 @oseoin @vepatel