Skip to content

nap modules base image #5197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 7, 2024
Merged

nap modules base image #5197

merged 5 commits into from
Mar 7, 2024

Conversation

@pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Mar 5, 2024 •
edited
Loading

Proposed changes

  • Addresses cases where base images needed to be rebuilt but were always trying to apply NAP configurations to the base image.
  • Address bug in md5sum generation for base images

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 force-pushed the nap_modules-base-image branch 2 times, most recently from f5d2595 to 203bdd1 Compare March 6, 2024 09:35
@pdabelf5 pdabelf5 marked this pull request as ready for review March 6, 2024 09:36
@pdabelf5 pdabelf5 requested a review from a team as a code owner March 6, 2024 09:36
vepatel
vepatel reviewed Mar 6, 2024
View reviewed changes
@pdabelf5 pdabelf5 force-pushed the nap_modules-base-image branch 9 times, most recently from 05b427b to 73ad49d Compare March 7, 2024 08:16
@pdabelf5 pdabelf5 force-pushed the nap_modules-base-image branch from 73ad49d to af1865e Compare March 7, 2024 08:45
@pdabelf5 pdabelf5 self-assigned this Mar 7, 2024
@pdabelf5 pdabelf5 merged commit 6a1dea0 into main Mar 7, 2024
@pdabelf5 pdabelf5 deleted the nap_modules-base-image branch March 7, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vepatel vepatel vepatel approved these changes

+2 more reviewers

@oseoin oseoin oseoin approved these changes

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pdabelf5 pdabelf5

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pdabelf5 @oseoin @vepatel @jjngx