Skip to content

Conversation

@pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Mar 5, 2025

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added documentation Pull requests/issues for documentation go Pull requests that update Go code python Pull requests that update Python code tests Pull requests that update tests labels Mar 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/7473/

@codecov
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 67.74194% with 20 lines in your changes missing coverage. Please review.

Project coverage is 52.04%. Comparing base (df17906) to head (3b71976).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/configs/virtualserver.go 79.48% 7 Missing and 1 partial ⚠️
internal/configs/warnings.go 0.00% 7 Missing ⚠️
internal/k8s/controller.go 50.00% 3 Missing ⚠️
internal/configs/version2/http.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7473      +/-   ##
==========================================
+ Coverage   51.77%   52.04%   +0.26%     
==========================================
  Files          89       89              
  Lines       21267    21309      +42     
==========================================
+ Hits        11011    11090      +79     
+ Misses       9815     9755      -60     
- Partials      441      464      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot removed the documentation Pull requests/issues for documentation label Mar 6, 2025
@AlexFenlon AlexFenlon linked an issue Mar 6, 2025 that may be closed by this pull request
3 tasks
@pdabelf5 pdabelf5 closed this Mar 17, 2025
@pdabelf5 pdabelf5 deleted the rate-limit-sync-scale branch March 17, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code python Pull requests that update Python code tests Pull requests that update tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants