Skip to content

Conversation

@salonichf5
Copy link
Contributor

Proposed changes

Cherry-pick PR for 4105

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Add support to make endpoint picker communication settings configurable.

Problem: User should be able to configure Endpoint picker connection flags

Solution: Adds command line support for endpoint picker flags
@salonichf5 salonichf5 requested a review from a team as a code owner October 29, 2025 16:18
@github-actions github-actions bot added documentation Improvements or additions to documentation chore Pull requests for routine tasks helm-chart Relates to helm chart labels Oct 29, 2025
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 72.50000% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.12%. Comparing base (6d58c4b) to head (f034ceb).
⚠️ Report is 1 commits behind head on release-2.2.

Files with missing lines Patch % Lines
cmd/gateway/commands.go 77.77% 6 Missing ⚠️
cmd/gateway/endpoint_picker.go 0.00% 3 Missing ⚠️
internal/controller/manager.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.2    #4189      +/-   ##
===============================================
+ Coverage        86.07%   86.12%   +0.05%     
===============================================
  Files              131      131              
  Lines            14200    14230      +30     
  Branches            74       74              
===============================================
+ Hits             12223    12256      +33     
+ Misses            1776     1773       -3     
  Partials           201      201              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@salonichf5 salonichf5 merged commit eeaaedb into release-2.2 Oct 29, 2025
68 of 69 checks passed
@salonichf5 salonichf5 deleted the chore/cherry-pick-epp branch October 29, 2025 17:07
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks documentation Improvements or additions to documentation helm-chart Relates to helm chart release-notes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants