Skip to content

Conversation

@sjberman
Copy link
Collaborator

Problem: When the Inference Extension was enabled, the additional container was not given resource specifications, which prevented the HPA from working.

Solution: Add the resource specifications from the NGINX container to the inference container.
Testing: Manually verified that HPA now works with inference enabled

Closes #4245

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Fix bug that prevented HPA from working when Inference Extension was enabled.

Problem: When the Inference Extension was enabled, the additional container was not given resource specifications, which prevented the HPA from working.

Solution: Add the resource specifications from the NGINX container to the inference container.
@sjberman sjberman requested a review from a team as a code owner November 10, 2025 18:53
@github-actions github-actions bot added the bug Something isn't working label Nov 10, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.10%. Comparing base (b960d89) to head (391b5bb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4247      +/-   ##
==========================================
+ Coverage   86.08%   86.10%   +0.01%     
==========================================
  Files         131      131              
  Lines       14171    14174       +3     
  Branches       35       35              
==========================================
+ Hits        12199    12204       +5     
+ Misses       1768     1766       -2     
  Partials      204      204              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman sjberman merged commit e1e2e73 into main Nov 10, 2025
62 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Nov 10, 2025
@sjberman sjberman deleted the bug/inference-hpa branch November 10, 2025 21:02
sjberman added a commit that referenced this pull request Nov 10, 2025
Problem: When the Inference Extension was enabled, the additional container was not given resource specifications, which prevented the HPA from working.

Solution: Add the resource specifications from the NGINX container to the inference container.
sjberman added a commit that referenced this pull request Nov 11, 2025
Problem: When the Inference Extension was enabled, the additional container was not given resource specifications, which prevented the HPA from working.

Solution: Add the resource specifications from the NGINX container to the inference container.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working release-notes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Enabling GWInference in helm chart breaks HPA

4 participants