Skip to content

Conversation

@sjberman
Copy link
Collaborator

@sjberman sjberman commented Dec 11, 2025

Update packages for CVEs. Also removed unnecessary library from UBI build.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


Since the OSS docker image uses an nginx image as the base, the alpine base is delayed in getting updates when there are CVEs and such.

This updates the apk packages to ensure that everything is always up to date for that distribution. Also removed unnecessary library from UBI build.
@sjberman sjberman requested a review from a team as a code owner December 11, 2025 15:45
@github-actions github-actions bot added the chore Pull requests for routine tasks label Dec 11, 2025
@sjberman sjberman requested a review from Copilot December 11, 2025 15:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Dockerfile configurations to improve package security and maintenance by ensuring Alpine Linux packages are kept up-to-date and removing unnecessary dependencies from UBI builds.

Key changes:

  • Added package update and upgrade step to Alpine-based NGINX OSS Dockerfile
  • Removed unnecessary shadow-utils installation and cleanup from NGINX Plus UBI Dockerfile
  • Updated comment consistency across Dockerfiles

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
build/Dockerfile.nginx Adds apk update && apk upgrade to keep Alpine packages current
build/ubi/Dockerfile.nginxplus Removes shadow-utils package installation and cleanup since useradd is available in base image
build/ubi/Dockerfile.nginx Updates comment to remove redundant context

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.03%. Comparing base (f536ed9) to head (671b300).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4448   +/-   ##
=======================================
  Coverage   86.03%   86.03%           
=======================================
  Files         132      132           
  Lines       14382    14382           
  Branches       35       35           
=======================================
+ Hits        12373    12374    +1     
+ Misses       1794     1793    -1     
  Partials      215      215           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman sjberman force-pushed the chore/dockerfile-fixes branch from a25e5d7 to 130285e Compare December 11, 2025 18:48
@sjberman sjberman enabled auto-merge (squash) December 11, 2025 21:02
@sjberman sjberman merged commit 54fe0f0 into main Dec 11, 2025
61 checks passed
@sjberman sjberman deleted the chore/dockerfile-fixes branch December 11, 2025 22:42
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants