-
Notifications
You must be signed in to change notification settings - Fork 154
Update dockerfile packages #4448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since the OSS docker image uses an nginx image as the base, the alpine base is delayed in getting updates when there are CVEs and such. This updates the apk packages to ensure that everything is always up to date for that distribution. Also removed unnecessary library from UBI build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates Dockerfile configurations to improve package security and maintenance by ensuring Alpine Linux packages are kept up-to-date and removing unnecessary dependencies from UBI builds.
Key changes:
- Added package update and upgrade step to Alpine-based NGINX OSS Dockerfile
- Removed unnecessary shadow-utils installation and cleanup from NGINX Plus UBI Dockerfile
- Updated comment consistency across Dockerfiles
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| build/Dockerfile.nginx | Adds apk update && apk upgrade to keep Alpine packages current |
| build/ubi/Dockerfile.nginxplus | Removes shadow-utils package installation and cleanup since useradd is available in base image |
| build/ubi/Dockerfile.nginx | Updates comment to remove redundant context |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4448 +/- ##
=======================================
Coverage 86.03% 86.03%
=======================================
Files 132 132
Lines 14382 14382
Branches 35 35
=======================================
+ Hits 12373 12374 +1
+ Misses 1794 1793 -1
Partials 215 215 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a25e5d7 to
130285e
Compare
Update packages for CVEs. Also removed unnecessary library from UBI build.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.