Skip to content

Conversation

@Gamecock
Copy link
Contributor

Addresses issues running unt test on windows except unicode characters in URLs.

Primary changes:

  1. adding quotes to variable expansions: "${variable}" vs ${variable} to handle spaces in path names.
  2. MSYS_NO_PATHCONV=1 added to resolve automatic path conversion docker run --entrypoint bug under MINGW64  docker/for-win#6754 (comment)

Based on #42 will be cleaner after it is merged.

@dekobon or @Victrid can you confirm no impact on linux unit test?

@Gamecock Gamecock changed the title Issue/45 Support unit test on Windows machine Aug 11, 2022
Copy link
Collaborator

@dekobon dekobon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dekobon dekobon closed this in 7a147b3 Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants