Fixing flaky ASAN CI build. #800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeioex
force-pushed
the
fix_flacky_asan_tests
branch
from
6709fc9 to
ff9f365
Compare
Previously, when an exception was thrown, the exception got 'stack' property attached which contained the backtrace information about where the exception happened. This could be a heavy operation and it was not always needed. To optimize it, the process is split into 2 phases. The first phase collects all the necessary info about the current stack. The second phase, where the stack symbolization happens, occurs only when this property is referenced.
xeioex
force-pushed
the
fix_flacky_asan_tests
branch
from
ff9f365 to
74f633a
Compare
VadimZhestikov
approved these changes
Oct 17, 2024
Contributor
VadimZhestikov
left a comment
VadimZhestikov
left a comment
There was a problem hiding this comment.
Both commits looks good. "Lazy stack symbolization" nice catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.