Quickjs ng 0.11.0

[xeioex]

No description provided.

[BalkanMadman]

One more request, please. Could you please call pkg-config via a variable ${PKG_CONFIG} that holds the path to pkg-config and defaults to pkg-config.

The use for the variable is cross-compilation where the required pkg-config might not be in path and needs to be specified explicitly.

[BalkanMadman]

Otherwise, LGTM.

[BalkanMadman]

Basically, like this: https://github.com/BalkanMadman/njs/blob/b31b34ae941d19bc13524dfec2519283aa09baa6/auto/quickjs#L10-L12:

# Alternative pkg-config binary can be supplied by setting the PKG_CONFIG
# environment variable.
: "${PKG_CONFIG:=pkg-config}"

[xeioex]

@BalkanMadman

One more request, please. Could you please call pkg-config via a variable ${PKG_CONFIG} that holds the path to pkg-config and defaults to pkg-config.

I prefer to not have ad-hoc variables for various tools. You have to add variables anyway, so modifying PATH or PKG_CONFIG_PATH looks like a better option for me. As I did in CI.

With other feedback, I do not mind applying your changes. Will do it later.

[BalkanMadman]

I prefer to not have ad-hoc variables for various tools. You have to add variables anyway, so modifying PATH or PKG_CONFIG_PATH looks like a better option for me. As I did in CI.

With other feedback, I do not mind applying your changes. Will do it later.

Reasonable, thank you!

[BalkanMadman]

Thank you for polishing the idea! LGTM

[VadimZhestikov]

Looks good