Skip to content

Conversation

@mtbChef
Copy link
Collaborator

@mtbChef mtbChef commented Nov 7, 2023

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@mtbChef mtbChef requested review from thresheek and y82 November 7, 2023 21:31
@thresheek
Copy link

LGTM

As a side note, maybe we also want to describe the installation for NGINX Plus. But this suggestion does not block this PR from getting merged in my opinion.

Copy link

@y82 y82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtbChef mtbChef merged commit fc7e69a into main Nov 7, 2023
@p-pautov p-pautov deleted the readme-add-package-install-steps branch March 12, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants